Changing cache location and deleting old files #414
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alex-fang0
requested review from
boarnoah,
scowing,
jharoutuniand2l and
gord5500
boarnoah
reviewed
Oct 31, 2023
gord5500
previously approved these changes
Oct 31, 2023
added 2 commits
October 31, 2023 12:18
alex-fang0
commented
Oct 31, 2023
boarnoah
reviewed
Oct 31, 2023
src/D2L.Bmx/Program.cs
Outdated
Comment on lines
219
to
224
| if( !Directory.Exists( BmxPaths.CACHE_DIR ) ) { | ||
| Directory.CreateDirectory( BmxPaths.CACHE_DIR ); | ||
| File.Delete( Path.Join( BmxPaths.BMX_DIR, "awsCredsCache" ) ); | ||
| File.Delete( Path.Join( BmxPaths.BMX_DIR, "sessions" ) ); | ||
| File.Delete( Path.Join( BmxPaths.BMX_DIR, "update_check" ) ); | ||
| } |
There was a problem hiding this comment.
Makes sense to handle exceptions gracefully here for the especially for the cleanup of the old files.
There was a problem hiding this comment.
I don't think the Directory or File functions error out even if the files don't exist
There was a problem hiding this comment.
Mhm, I was more concerned about the other exceptions. Especially for the cleanup part of this (i.e everything aside from CreateDirectory).
https://learn.microsoft.com/en-us/dotnet/api/system.io.file.delete?view=net-7.0#exceptions
Ideally we would like BMX to continue working if for w/e reason it can't actually delete those files.
There was a problem hiding this comment.
Gotcha! makes sense
|
PR #415 created to format .cs files. |
Auto format cache/file-location Co-authored-by: DotNet Format Bot <[email protected]>
boarnoah
reviewed
Oct 31, 2023
boarnoah
approved these changes
Nov 3, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why
User looking to modify the config file manually may get confused by all the different files in .bmx